Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to actions #276

Merged
merged 5 commits into from
May 23, 2024
Merged

changes to actions #276

merged 5 commits into from
May 23, 2024

Conversation

ronanstokes-db
Copy link
Contributor

@ronanstokes-db ronanstokes-db commented May 23, 2024

Proposed changes

Updated build actions to use later versions to avoid use of deprecated versions of build actions.
Use explicit token to upload code coverage files as version without token is throttled.

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

Needed due to Github deprecation of some build actions and changes to how tests are run

@ronanstokes-db ronanstokes-db requested a review from a team as a code owner May 23, 2024 18:35
@ronanstokes-db ronanstokes-db requested review from GeekSheikh and removed request for a team May 23, 2024 18:35
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (1113d73) to head (c356ab2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   92.22%   92.14%   -0.08%     
==========================================
  Files          23       23              
  Lines        2764     2788      +24     
  Branches      472      477       +5     
==========================================
+ Hits         2549     2569      +20     
- Misses        128      130       +2     
- Partials       87       89       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronanstokes-db ronanstokes-db merged commit 02d529e into master May 23, 2024
5 checks passed
@ronanstokes-db ronanstokes-db deleted the feature_updated_buildactions branch May 23, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants