Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-134006 use dev target and minor tweaks #11

Conversation

liamlynch-data
Copy link
Contributor

Adding a make dev so we can build local changes without committing
Tweaked the plugin target so if it is used (by copying) in projects with no tests yet the build does not fail with an error

@shortcut-integration
Copy link

@liamlynch-data
Copy link
Contributor Author

I think there is a problem with this actually
make dist-clean should not go first

@liamlynch-data
Copy link
Contributor Author

I think there is a problem with this actually make dist-clean should not go first

has been fixed now - all should be ok

Copy link

@alexbourret alexbourret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamlynch-data liamlynch-data merged commit a8db285 into main May 22, 2023
2 checks passed
@liamlynch-data liamlynch-data deleted the feature/dss12-sc-134006-change-the-zip-command-to-build-the-plugin branch May 22, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants