Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at using Linkedom instead of microlink #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rknightuk
Copy link

Uses Linkedom and probe-image-size to get a similar set of same data without relying on a third party service.

Some quick tests show a big improvement in speed:

The 3 demo links:
microlink: 3.99 seconds
linkedom: 1.98 seconds

10 random links:
microlink: 20.36 seconds
linkedom: 5.80 seconds

Moving to this adds more chance of missing data, would be worth adding tests to cover each of the selectors.

Would also be worth investigating using the metascaper packages instead for getting the data.

Also includes the same changes that are in #3 (custom cache, updated readme)

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for eleventy-plugin-unfurl failed.

Name Link
🔨 Latest commit 323196f
🔍 Latest deploy log https://app.netlify.com/sites/eleventy-plugin-unfurl/deploys/64adb4ab1750760008c860f7

README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants