fix: MapUtil.get return type, with function overloading #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elegantcoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 의 종류는 어떤 것인가요?
수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)
MapUtil.get 은 defaultValue 를 받을 수 있습니다.
이것을 Map.get() 이 undefined 유니언 타입을 리턴하는 것에 대한 방어 차원으로 사용할 수 있습니다.
그런데 용도에 맞지 않게 undefined 유니언 타입이 리턴되고 있어 함수 오버로딩을 통해 지원하도록 수정했습니다.
무엇을 어떻게 변경했나요?
코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.
디펜던시 변경이 있나요?
어떻게 테스트 하셨나요?
코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.