add vsock connection tests #846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have an automatically created pr for nix update and cargo.lock isn't really something that affects users. Please don't touch it directly. Bots take care of it. |
|
@zeenix any idea why tokio-vsock doesn't receive BEGIN.. or how to debug that.. I am bit stuck. (cargo test --features tokio-vsock,p2p connection::p2p_tests::vsock_connect) |
zeenix
reviewed
Jul 1, 2024
zeenix
reviewed
Jul 1, 2024
Seems to be only an issue for |
|
@elmarco do you see this PR going forward? |
This is backward since commit cf35fbd and triggers extra compilation warning (target_family vs target_os). Let's drop it.
Use local CID, and bind to any port. If vsock is enabled, assume the host is capable to run the tests.
zeenix
reviewed
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails with tokio-vsock, which doesn't seem to send or flush the BEGIN command. More investigation needed.