v2.0 add unit-tests for tbl_survfit for add_n, add_nevent, add_p #1753
+57,899
−21,040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* progress * Update NEWS.md * Update NEWS.md
* in progress * progress
* updates * more updates * Update test-coverage.yaml * Update pull_request_template.md * updates * updates
* in progress * progress
* in progress * progress * progress
* in progress * Update tbl_summary.R
* moving indentation to its own table styling enttry * Update NEWS.md
* updates * updates
* Add tests * Add unit tests for as_tibble * Remove comment * Update tbl_stack.R * Use base R pipe * Add test for column grouping * A bit of clean up * Comment code * Remove some snapshot tests * Add test for as.data.frame --------- Co-authored-by: Daniel Sjoberg <[email protected]>
…()` (#1725) * add test for add_n.tbl_uvregression() * all tests added and styler * forgot a skip_if_not * adopt feedback * adopt feedback
* adding kabel extra output * adding indent
* rename some functions * Update _pkgdown.yml
* Add tests for as_gt * Fix * Fix * Fix * Test * Test * Rearrange existing * Add tests for as_gt * Update footnotes test * Simplify interpreter test * Add footnotes test * Clean up * Add test for bold/italics * Add test for missing symbols * Add test for column merging * Simplify tests * Add test for missing values * Add tests for formatting functions --------- Co-authored-by: Daniel Sjoberg <[email protected]>
|
@zdz2101 is this ready for review? |
Ahh yes I forgot to assign you, this is ready! |
|
Hey! I am going to hold off reviewing these updates until we get the tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
If there is an GitHub issue associated with this pull request, please provide link.
Reviewer Checklist (if item does not apply, mark is as complete)
renv::install()tbl_summary(), was the same change implemented fortbl_svysummary()?_pkgdown.ymlpkgdown::build_site(). Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Begin in a fresh R session without any packages loaded.usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")codemetar::write_codemeta()usethis::use_spell_check()again