Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script tags to .js file #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BoatrightTBC
Copy link

Custom Content Creator injects the BARE CONTENTS of the .js file, not a link to it. As a result, the javascript is not wrapped in script tags and does not execute. So I put script tags in the .js file.

@dedevillela
Copy link
Owner

Hi BoatrightTBC, and thanks for pointing that out.

For your knowledge, the code does not contain the <script> tags for CI validation purposes.

By the way, I have added instructions to the Readme file so that the plugin works properly.

Best regards,

Andre Villela

@BoatrightTBC
Copy link
Author

OK, for my sake (and you can close this if you like and ignore it) I created source and release folders with two versions of the JS.

I also updated the readme to reflect that rather than trusting people to edit source code, and fixed a few grammer and formatting issues in the readme.

I'll persist that branch of my repo so I can link to it whether you merge or not.

Thanks for the quick reply.

@dedevillela
Copy link
Owner

Hi BoatrightTBC, and sorry for the delay! I'd love to merge you pull request, but the Codacy checks revealled some issues with code standards, mostly can be resolved with comment placement for variable declarations. There's also conflicts with the README and the script file; once its all good I'll proceed with the PR. Thanks again for your input, time and effort while contributing to this project!

Kind regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants