Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(injector): improve set method api #557

Merged

Conversation

marcus-sa
Copy link
Contributor

Summary of changes

Relinquishment of Rights

Please mark following checkbox to confirm that you relinquish all rights of your changes:

  • I waive and relinquish all rights regarding this changes (including code, text, and images) to Deepkit UG (limited), Germany. This changes (including code, text, and images) are under MIT license without name attribution, copyright notice, and permission notice requirement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 92.71255% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 78.02%. Comparing base (3e09ddf) to head (0221a8b).
Report is 43 commits behind head on master.

❗ Current head 0221a8b differs from pull request most recent head 901bd24. Consider uploading reports for the commit 901bd24 to get more accurate results

Files Patch % Lines
packages/rpc/src/decorators.ts 75.00% 4 Missing ⚠️
packages/rpc/src/server/action.ts 93.33% 4 Missing ⚠️
packages/rpc/src/server/kernel.ts 92.45% 4 Missing ⚠️
packages/type/src/serializer.ts 75.00% 2 Missing ⚠️
packages/type/src/utils.ts 0.00% 2 Missing ⚠️
packages/broker/src/kernel.ts 75.00% 1 Missing ⚠️
packages/type/src/reflection/reflection.ts 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   78.06%   78.02%   -0.05%     
==========================================
  Files         191      149      -42     
  Lines       20296    18291    -2005     
  Branches     5255     4864     -391     
==========================================
- Hits        15844    14271    -1573     
+ Misses       4452     4020     -432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcus-sa marcus-sa requested a review from marcj March 7, 2024 13:09
@marcj marcj merged commit eb92e58 into deepkit:master Mar 7, 2024
6 checks passed
@marcj
Copy link
Member

marcj commented Mar 7, 2024

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants