Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove hpa modified from packager #2696

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phillebaba
Copy link
Member

Description

This change removes the hpa modified property from packager. Instead it will always set the registry to the expected scale policy no matter if it has been modified or not. The additional API calls are worth the reduction in complexity.

A note for the future is that the purpose for disabling scale down of the registry has to be documented. It is not totally clear why this is done.

Related Issue

Relates to #2694

Checklist before merging

@phillebaba phillebaba requested review from dgershman and a team as code owners July 3, 2024 11:43
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit b334201
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66853949b2e46500081a40b6

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 19.00%. Comparing base (43e50bb) to head (b334201).

Files Patch % Lines
src/pkg/packager/deploy.go 0.00% 9 Missing ⚠️
src/pkg/cluster/zarf.go 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
- Coverage   19.00%   19.00%   -0.01%     
==========================================
  Files         170      170              
  Lines       12199    12200       +1     
==========================================
  Hits         2318     2318              
+ Misses       9595     9594       -1     
- Partials      286      288       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant