Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect HTTPS traffic to HTTPS #85

Merged
merged 1 commit into from
Nov 28, 2023
Merged

redirect HTTPS traffic to HTTPS #85

merged 1 commit into from
Nov 28, 2023

Conversation

missytake
Copy link
Contributor

fix #81

After we merged #75 we should rebase this (or the other way round), as nginx.conf is changed there as well.

@missytake
Copy link
Contributor Author

To verify this works, run:

curl -i http://c2.testrun.org/.well-known/autoconfig/mail/config-v1.1.xml -L

and compare it to the status quo (or rather, the state of #75):

curl -i http://c1.testrun.org/.well-known/autoconfig/mail/config-v1.1.xml -L

listen [::]:80 default_server;
server_name _;

return 301 https://$host$request_uri;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with letsencrypt queries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure, because that's also what we use at other nginx servers, but we can try it with c4.testrun.org.

Copy link
Contributor

@link2xt link2xt Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least some of our nginx servers use acmetool in redirector mode where it serves HTTP for challenges and HTTP-to-HTTPS redirects.

But Let's Encrypt says it follows redirects, so this setup should work: https://letsencrypt.org/docs/challenge-types/#http-01-challenge

@hpk42 hpk42 merged commit 5eb5c09 into main Nov 28, 2023
4 checks passed
@missytake missytake deleted the https-redirect branch November 28, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http should redirect to https
3 participants