-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/test): improve test output readability #24357
base: main
Are you sure you want to change the base?
Conversation
@iuioiua after a but of struggle i think i managed to fix this. Couple of things to note:
Produces
I think its because of the
I am not sure if this looks better or worse. What are your thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like the correct approach. My understanding was that we just needed to prepend a couple of spaces, or increase description.level
by 1, in the following lines:
deno/cli/tools/test/reporters/pretty.rs
Line 84 in 8d14a9d
"{}{} ...", |
deno/cli/tools/test/reporters/pretty.rs
Line 361 in 8d14a9d
"{} {} ...", |
Can you try that?
Also, looking at the output, I'm having 2nd thoughts on whether we should do the indent. Perhaps, just having the grayed text will suffice. Either way, let's see how it all looks 🙂
Indent last line of tests that contain multiple steps.
fc94eb5
to
ee32ccf
Compare
Indent last line of tests that contain multiple steps.
Closes #24071