Remove ch33 files

[ryan-mcneil]

Summary

• Removes ch33 files (see note+comment below) ahead of a gem bump to remove unnecessary work.

NOTE: Copying the following from a PR started by @tpharrison. I cherry-picked his commit to a branch from master instead of a stale branch of mine so that we could commit these changes separately:

@ryan-mcneil See my comments for more background on these changes.

The following are related to CH33 and have been removed (or updated):

# CH33 controller and spec...
deleted:    app/controllers/v0/profile/ch33_bank_accounts_controller.rb
deleted:    spec/controllers/v0/profile/ch33_bank_accounts_controller_spec.rb

# CH33 VCR cassettes...
deleted:    spec/support/vcr_cassettes/bgs/ddeft/find_bank_name_invalid_routing.yml
deleted:    spec/support/vcr_cassettes/bgs/ddeft/find_bank_name_valid.yml
deleted:    spec/support/vcr_cassettes/bgs/service/find_ch33_dd_eft.yml
deleted:    spec/support/vcr_cassettes/bgs/service/find_ch33_dd_eft_no_bank_info.yml
deleted:    spec/support/vcr_cassettes/bgs/service/find_ch33_dd_eft_no_icn.yml
deleted:    spec/support/vcr_cassettes/bgs/service/update_ch33_dd_eft.yml

# Removed specs that referenced the above VCR cassettes...
modified:   spec/lib/bgs/service_spec.rb
modified:   spec/models/bank_name_spec.rb
modified:   spec/requests/swagger_spec.rb

The bgs/service/find_rating_data cassette is still being referenced by the health_care_applications_controller which is owned by the 1010 team. You can reach out to them in the #1010-health-apps channel.

Most VFS teams have migrated to Lighthouse's Veteran Service History and Eligibility API for a veteran's rating data. If the 1010 team decides to migrate (recommended), then this cassette and it's dependencies can be removed as well.

Drop me a line when you get back and we can review and determine if there is anything else I can help out with.

---

Related issue(s)

• [VETS-API] Gem Update: Bump savon to latest (2.15.x) va.gov-team#74433

Testing done

• Specs passing after removing files

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/models/bank_name_spec.rb

[github-actions]

1 Error

🚫

This PR changes 602 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .github/CODEOWNERS (+0/-7) app/controllers/v0/profile/ch33_bank_accounts_controller.rb (+0/-39) app/models/bank_name.rb (+0/-20) app/policies/ch33_dd_policy.rb (+0/-11) app/serializers/ch33_bank_account_serializer.rb (+0/-18) app/services/users/profile.rb (+0/-1) config/routes.rb (+0/-2) lib/bgs/service.rb (+0/-50) spec/controllers/v0/profile/ch33_bank_accounts_controller_spec.rb (+0/-131) spec/controllers/v0/users_controller_spec.rb (+0/-2) spec/factories/bank_name.rb (+0/-6) spec/lib/bgs/service_spec.rb (+0/-136) spec/models/bank_name_spec.rb (+0/-31) spec/policies/ch33_dd_policy_spec.rb (+0/-26) spec/requests/swagger_spec.rb (+0/-78) spec/serializers/ch33_bank_account_serializer_spec.rb (+0/-44) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/models/bank_name_spec.rb

[github-actions]

Backend-review-group approval confirmed.