Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API-39196] Add transaction_id to 526 synchronous logs #18210

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[API-39196] Add transaction_id to 526 synchronous logs #18210

merged 2 commits into from
Sep 3, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Aug 27, 2024 •
edited
Loading

Summary

Add transaction_id to:

  • Docker container service logs
  • PDF generation service logs
  • EVSS service logs

Related issue(s)

API-39196

Testing done

  • New code is covered by unit tests

Screenshots

N/A

What areas of the site does it impact?

526 synchronous endpoint, including:

  • Docker container service
  • PDF generation service
  • EVSS service

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Aug 27, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-transaction-id-to-526-logs/main/main August 27, 2024 18:07 Inactive
@tycol7 tycol7 force-pushed the tdc/add-transaction-id-to-526-logs branch from 23e7b21 to 8fd12e6 Compare August 27, 2024 18:56
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-transaction-id-to-526-logs/main/main August 27, 2024 18:57 Inactive
@tycol7 tycol7 force-pushed the tdc/add-transaction-id-to-526-logs branch from 8fd12e6 to 3c80819 Compare August 27, 2024 19:05
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-transaction-id-to-526-logs/main/main August 27, 2024 19:07 Inactive
@tycol7 tycol7 force-pushed the tdc/add-transaction-id-to-526-logs branch from 3c80819 to 790e20b Compare August 27, 2024 20:19
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-transaction-id-to-526-logs/main/main August 27, 2024 20:29 Inactive
@tycol7 tycol7 force-pushed the tdc/add-transaction-id-to-526-logs branch from 790e20b to 98d4f30 Compare August 27, 2024 21:20
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-transaction-id-to-526-logs/main/main August 27, 2024 21:26 Inactive
@tycol7
Add transaction_id to 526 synchronous logs
fa78d17 
Add `transaction_id` to:
* Docker container service logs
* PDF generation service logs
* EVSS service logs
@tycol7 tycol7 force-pushed the tdc/add-transaction-id-to-526-logs branch from 98d4f30 to fa78d17 Compare August 27, 2024 23:01
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/add-transaction-id-to-526-logs/main/main August 27, 2024 23:02 Inactive
@tycol7 tycol7 marked this pull request as ready for review August 28, 2024 20:37
@tycol7 tycol7 requested a review from a team as a code owner August 28, 2024 20:37
@stiehlrod
Copy link
Contributor

Hey @tycol7, I am not seeing the transaction_id come through in the logs.
Screenshot 2024-08-29 at 8 50 35 AM

@tycol7
Copy link
Contributor Author

tycol7 commented Aug 29, 2024

Hey @tycol7, I am not seeing the transaction_id come through in the logs. Screenshot 2024-08-29 at 8 50 35 AM

Did your claim have a transaction_id? We will omit transaction_id if not on the claim.

@stiehlrod
Copy link
Contributor

Hey @tycol7, I am not seeing the transaction_id come through in the logs. Screenshot 2024-08-29 at 8 50 35 AM

Did your claim have a transaction_id? We will omit transaction_id if not on the claim.

Got it, my apologies.

@rjohnson2011 rjohnson2011 self-requested a review August 29, 2024 19:30
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

@tycol7 tycol7 merged commit baca476 into master Sep 3, 2024
31 of 40 checks passed
@tycol7 tycol7 deleted the tdc/add-transaction-id-to-526-logs branch September 3, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@stiehlrod stiehlrod stiehlrod approved these changes

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

Assignees
No one assigned
Labels
claimsApi modules/claims_api require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tycol7 @stiehlrod @rjohnson2011 @va-vfs-bot