Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Covid Research & Covid Vaccine Request Specs #18218

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

stevenjcumming
Copy link
Contributor

Summary

  • Files were renamed to follow convention (detailed at the bottom)
  • Top-level example groups were renamed to follow convention

Related issue(s)

Testing done

  • No new tests

Acceptance criteria

  • The tests pass
  • request specs files are named and organized based on established convention
  • request specs example group names are named based on established convention

Copy link

1 Error
🚫 This PR changes 619 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/covid_research/spec/requests/{volunteer_request_spec.rb => covid_research/volunteer_spec.rb} (+1/-1)

  • modules/covid_vaccine/spec/request/covid_vaccine/v0/{expanded_registration_request_spec.rb => expanded_registration_spec.rb} (+1/-1)

  • modules/covid_vaccine/spec/request/covid_vaccine/v0/{facilities_request_spec.rb => facilities_spec.rb} (+1/-1)

  • modules/covid_vaccine/spec/request/covid_vaccine/v0/{registration_request_spec.rb => registration_spec.rb} (+3/-3)

  • modules/covid_vaccine/spec/requests/covid_vaccine/v0/expanded_registration_spec.rb (+214/-0)

  • modules/covid_vaccine/spec/requests/covid_vaccine/v0/facilities_spec.rb (+73/-0)

  • modules/covid_vaccine/spec/requests/covid_vaccine/v0/registration_spec.rb (+320/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link

Backend-review-group approval confirmed.

@stevenjcumming stevenjcumming merged commit 3d393e5 into master Aug 28, 2024
23 of 25 checks passed
@stevenjcumming stevenjcumming deleted the sjc-covid-request-spec-reorg branch August 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants