Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE | Ask VA Api: translate category id to category name #18219

Merged

Conversation

Khoa-V-Nguyen
Copy link
Contributor

@Khoa-V-Nguyen Khoa-V-Nguyen commented Aug 27, 2024

Summary

This PR enhances the Inquiries::Retriever class and updates related tests and mock data:

Changes Made

  • Enhancement of Inquiries::Retriever:
    • Implemented translation of category_id to category_name to improve data readability and consistency.

-**Add created_on to Correspondences::Entity and Correspondences::Serializer

  • Test Updates:

    • Updated test user identifier from test_user_228 to test_user_229 to reflect the latest test scenarios.
  • Mock Data Adjustments:

    • Refreshed mock files to align with the updated logic and data structure changes.
  • Spec Modifications:

    • Revised specs to accommodate the changes in Retriever functionality and updated mock data.

Related issue(s)

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@va-vfs-bot va-vfs-bot temporarily deployed to ask-va-api-translate-category-id-to-category-name/main/main August 27, 2024 21:56 Inactive
hemeshvpatel
hemeshvpatel previously approved these changes Aug 27, 2024
Copy link

@hemeshvpatel hemeshvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

khoa-v-nguyen added 2 commits August 28, 2024 14:48
- Retriever now translate `category_id` to `category_name`
Copy link

@hemeshvpatel hemeshvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Backend-review-group approval confirmed.

@Khoa-V-Nguyen Khoa-V-Nguyen merged commit 1b8fa35 into master Aug 29, 2024
26 of 29 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-translate-category-id-to-category-name branch August 29, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants