-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE | Ask VA Api: translate category id to category name #18219
Merged
Khoa-V-Nguyen
merged 2 commits into
master
from
ask-va-api-translate-category-id-to-category-name
Aug 29, 2024
Merged
BE | Ask VA Api: translate category id to category name #18219
Khoa-V-Nguyen
merged 2 commits into
master
from
ask-va-api-translate-category-id-to-category-name
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
ask-va-api-translate-category-id-to-category-name/main/main
August 27, 2024 21:56
Inactive
hemeshvpatel
previously approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Khoa-V-Nguyen
force-pushed
the
ask-va-api-translate-category-id-to-category-name
branch
from
August 28, 2024 20:27
d522d32
to
4d3306a
Compare
- Retriever now translate `category_id` to `category_name`
Khoa-V-Nguyen
force-pushed
the
ask-va-api-translate-category-id-to-category-name
branch
from
August 28, 2024 20:49
1aaab3b
to
f463070
Compare
hemeshvpatel
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rjohnson2011
approved these changes
Aug 29, 2024
Backend-review-group approval confirmed. |
Khoa-V-Nguyen
deleted the
ask-va-api-translate-category-id-to-category-name
branch
August 29, 2024 19:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
Inquiries::Retriever
class and updates related tests and mock data:Changes Made
Inquiries::Retriever
:category_id
tocategory_name
to improve data readability and consistency.-**Add
created_on
toCorrespondences::Entity
andCorrespondences::Serializer
Test Updates:
test_user_228
totest_user_229
to reflect the latest test scenarios.Mock Data Adjustments:
Spec Modifications:
Retriever
functionality and updated mock data.Related issue(s)
Testing done
Acceptance criteria