Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIMPLE_FORMS] feat: update form 21-10210 with new pdf form and expiration date #18379

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[SIMPLE_FORMS] feat: update form 21-10210 with new pdf form and expiration date #18379

wants to merge 7 commits into from
+134 −53

Conversation

pennja
Copy link
Contributor

@pennja pennja commented Sep 10, 2024 •
edited
Loading

Summary

  • This work updates the form PDF template, form mappings, and stamp locations for newly updated form 21-10210

Related issue(s)

Testing done

  • Logic is already covered by unit tests

Requested Feedback

Any

@pennja pennja force-pushed the jap/simple-forms/1571-21-10210 branch from 0573643 to d717adb Compare September 10, 2024 17:44
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1571-21-10210/main/main September 10, 2024 18:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1571-21-10210/main/main September 10, 2024 23:41 Inactive
@pennja pennja force-pushed the jap/simple-forms/1571-21-10210 branch from d717adb to d449a1b Compare October 8, 2024 13:49
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1571-21-10210/main/main October 8, 2024 13:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1571-21-10210/main/main October 8, 2024 15:27 Inactive
@pennja pennja force-pushed the jap/simple-forms/1571-21-10210 branch from d4315a8 to 9034893 Compare October 8, 2024 15:29
@pennja pennja marked this pull request as ready for review October 8, 2024 15:30
@pennja pennja requested review from a team as code owners October 8, 2024 15:30
@pennja pennja changed the title [SIMPLE_FORMS] feat: WIP [SIMPLE_FORMS] feat: update form 21-10210 with new pdf form and expiration date Oct 8, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1571-21-10210/main/main October 8, 2024 16:10 Inactive
Thrillberg
Thrillberg previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Thrillberg Thrillberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the comments in the erb! Nice work!

modules/simple_forms_api/app/models/simple_forms_api/vba_21_10210.rb Show resolved Hide resolved
@pennja pennja force-pushed the jap/simple-forms/1571-21-10210 branch from 3a7ec3d to 490328d Compare October 8, 2024 19:32
Thrillberg
Thrillberg approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Thrillberg Thrillberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the spec fix too!

modules/simple_forms_api/spec/services/pdf_filler_spec.rb Show resolved Hide resolved
@pennja pennja enabled auto-merge (squash) October 8, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thrillberg Thrillberg Thrillberg approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pennja @Thrillberg @va-vfs-bot