Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT-580: Show conditional benefit received/applied for 1995 spool file & remove benefit feature flag #18598

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

alexchan-va
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): No
  • (Summarize the changes that have been made to the platform): Show conditional benefit received/applied for 1995 spool file & remove benefit feature flag
  • (If bug, how to reproduce): N/A
  • (What is the solution, why is this the solution?): Need to show benefit received when benefitAppliedFor is blank
  • (Which team do you work for, does your team own the maintenance of this component?): VEBT
  • (If introducing a flipper, what is the success criteria being targeted?): N/A

Related issue(s)

Testing done

  • [ x] New code is covered by unit tests
  • Describe what the old behavior was prior to the change Nothing was displayed if benefitAppliedFor was blank.
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing Submit 1995 form and check resulting spool file.

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas) 1995 spool file

Acceptance criteria

  • [x ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x ] No error nor warning in the console.
  • [x ] Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [ x] Feature/bug has a monitor built into Datadog (if applicable)

Copy link

Backend-review-group approval confirmed.

@alexchan-va alexchan-va merged commit 0611fc4 into master Sep 30, 2024
35 of 37 checks passed
@alexchan-va alexchan-va deleted the vebt-580 branch September 30, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants