Version bump of json-schema #18603
Draft
Version bump of json-schema #18603
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
lint-failure
and removed
require-backend-approval
labels
1 task
rmtolmach
reviewed
Sep 24, 2024
Gemfile.lock
Outdated
| @@ -1274,8 +1266,6 @@ DEPENDENCIES | |||
| shoulda-matchers | |||
| shrine | |||
| sidekiq (~> 7.2.0) | |||
| sidekiq-ent! | |||
| sidekiq-pro! | |||
There was a problem hiding this comment.
I don't think sidekiq things should be removed.
There was a problem hiding this comment.
Have you set the enterprise license key locally? https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/platform/engineering/sidekiq-enterprise-setup.md
There was a problem hiding this comment.
I have not. Thanks for the link.
va-vfs-bot
temporarily deployed
to
feature/bump-json-schema-gem-version-knight/main/main
va-vfs-bot
temporarily deployed
to
feature/bump-json-schema-gem-version-knight/main/main
rmtolmach
reviewed
Sep 25, 2024
Gemfile.lock
Outdated
| sidekiq-pro (>= 7.2.0, < 8) | ||
| sidekiq-pro (7.2.1) | ||
| base64 | ||
| sidekiq (>= 7.2.0, < 8) |
There was a problem hiding this comment.
This shouldn't be deleted, either.
va-vfs-bot
temporarily deployed
to
feature/bump-json-schema-gem-version-knight/main/main
rmtolmach
reviewed
Sep 25, 2024
Gemfile.lock
Outdated
| @@ -1254,7 +1265,7 @@ DEPENDENCIES | |||
| rspec-retry | |||
| rspec-sidekiq | |||
| rspec_junit_formatter | |||
| rswag-specs | |||
| rswag-specs! | |||
There was a problem hiding this comment.
There's a linting error. Is it because of this line? Here's the error:
> bundle install
/opt/hostedtoolcache/Ruby/3.3.3/x64/bin/bundle config --local path /home/runner/work/vets-api/vets-api/vendor/bundle
/opt/hostedtoolcache/Ruby/3.3.3/x64/bin/bundle config --local deployment true
Cache key: setup-ruby-bundler-cache-v6-ubuntu-22.04-x64-ruby-3.3.3-wd-/home/runner/work/vets-api/vets-api-with--without--only--Gemfile.lock-c9ad2785870190f70805105221380591329b5bba52f0e3f536054a375884bfcf
Received 0 of 194032542 (0.0%), 0.0 MBs/sec
Received 92274688 of 194032542 (47.6%), 44.0 MBs/sec
Cache Size: ~185 MB (194032542 B)
/usr/bin/tar -xf /home/runner/work/_temp/47c590d2-ec4a-49e0-949c-559c0514bb78/cache.tzst -P -C /home/runner/work/vets-api/vets-api --use-compress-program unzstd
Received 194032542 of 194032542 (100.0%), 61.7 MBs/sec
Cache restored successfully
Found cache for key: setup-ruby-bundler-cache-v6-ubuntu-22.04-x64-ruby-3.3.3-wd-/home/runner/work/vets-api/vets-api-with--without--only--Gemfile.lock-8523844df877ba4654c21875ffe959ac1b2147f0c65a9b095e3b0c09a3f244fa
/opt/hostedtoolcache/Ruby/3.3.3/x64/bin/bundle install --jobs 4
Your lockfile does not satisfy dependencies of "rswag-specs", but the lockfile
can't be updated because frozen mode is set
There was a problem hiding this comment.
The exclamation point is just for fetching via git instead of http, from what I can tell.
va-vfs-bot
temporarily deployed
to
feature/bump-json-schema-gem-version-knight/main/main
rmtolmach
reviewed
Sep 27, 2024
| @@ -216,7 +216,7 @@ group :development, :test do | |||
| gem 'rspec-instrumentation-matcher' | |||
| gem 'rspec-its' | |||
| gem 'rspec-rails' | |||
| gem 'rswag-specs' | |||
| gem 'rswag-specs', git: 'https://github.com/rswag/rswag', branch: 'master' | |||
There was a problem hiding this comment.
Maybe this line is causing the issue? Since it's not a repo we own we might not want to point to master for security reasons. Is there a tag we can do instead of master?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This work is behind a feature toggle (flipper):NO
There is a bug within json-schema where a schema version can be cached. This was Reference resolution issue voxpupuli/json-schema#514.
I have not been able to reproduce the error since it is cached related. I'll admit that I'm not sure if this change will fix the schema issues we have seen.
As part of the change apivore needed to be bumped up too.
Since there is no packaged release of json-schema, I've pointed to master
Related issue(s)
Testing done
Acceptance criteria