Part 1 of refactoring NotificationEmail

[Thrillberg]

Summary

I have a >1000 line PR that I'm breaking up into pieces. This is the first piece. This is basically a white-space change to begin removing a big loop for the whole test file (was a bad idea).

[github-actions]

1 Warning

⚠️

This PR changes 302 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/simple_forms_api/spec/services/notification_email_spec.rb (+150/-152) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[pennja]

Looks good to me! 👍

[github-actions]

Backend-review-group approval confirmed.

[Thrillberg]

I'm converting this to a draft because I don't want to embark on this refactoring until user_account is handled: #18727