Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nil in form_data properly for Form Submission Attempts #18774

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Handle nil in form_data properly for Form Submission Attempts #18774

merged 1 commit into from
Oct 7, 2024

Conversation

Thrillberg
Copy link
Contributor

Summary

This PR handles nil form_data in a non-destructive way (see the revert).

@Thrillberg Thrillberg requested review from a team as code owners October 7, 2024 17:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Backend-review-group approval confirmed.

pennja
pennja approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@pennja pennja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work! 👍

@Thrillberg Thrillberg merged commit 741a2f2 into master Oct 7, 2024
37 checks passed
@Thrillberg Thrillberg deleted the handle-nil-form-data-properly branch October 7, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindseySaari LindseySaari LindseySaari approved these changes

@ndsprinkle ndsprinkle ndsprinkle approved these changes

@pennja pennja pennja approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thrillberg @LindseySaari @ndsprinkle @pennja @va-vfs-bot