-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBX-94128] update 526 remediation model for email era #18779
base: master
Are you sure you want to change the base?
[DBX-94128] update 526 remediation model for email era #18779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR mentions removing the ignored_as_duplicate
value, does that mean removing a column? Or what does that mean.
Edit: NVM I see that as a follow up, so that is safe to do as another PR with a migration of data from that column to this new one?
@kylesoskin we can discuss how to migrate the data in subsequent work. but TL;DR we could do a one line rake task or just command line it |
Backend-review-group approval confirmed. |
Summary
remediation_type
value to toForm526SubmissionRemediation
tablemanual
ignored_as_duplicate
email_notification
ignored_as_duplicate: true
values to new paradigmignored_as_duplicate
valueThis will unblock iterations on our 526 Silent Failure work. We will use this new paradigm to automatically 'remediate' submissions when we notify a veteran via email of a failure
Related issue(s)
Testing done
What areas of the site does it impact?
Form526Submission silent failures
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?