Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBX-94128] update 526 remediation model for email era #18779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SamStuckey
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • migration to add remediation_type value to to Form526SubmissionRemediation table
  • follow ups
    • refactor the model to have an enum that leverages this value providing types
      • manual
      • ignored_as_duplicate
      • email_notification
    • migrate application logic
      • update existing ignored_as_duplicate: true values to new paradigm
      • update Form526Submission state scopes to use new paradigm
    • remove ignored_as_duplicate value

This will unblock iterations on our 526 Silent Failure work. We will use this new paradigm to automatically 'remediate' submissions when we notify a veteran via email of a failure

Related issue(s)

Testing done

  • New code is covered by unit tests (n/a)
  • nothing to test

What areas of the site does it impact?

Form526Submission silent failures

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@SamStuckey SamStuckey added disability-experience To manage benefits disability claims experience. ZSF:Email zero-silent-failures labels Oct 7, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-94128/update-526-remediation-model-for-email-era/main/main October 7, 2024 19:45 Inactive
Copy link
Contributor

@kylesoskin kylesoskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR mentions removing the ignored_as_duplicate value, does that mean removing a column? Or what does that mean.

Edit: NVM I see that as a follow up, so that is safe to do as another PR with a migration of data from that column to this new one?

@SamStuckey
Copy link
Contributor Author

@kylesoskin we can discuss how to migrate the data in subsequent work. but TL;DR we could do a one line rake task or just command line it

@SamStuckey SamStuckey marked this pull request as ready for review October 8, 2024 17:59
@SamStuckey SamStuckey requested review from a team as code owners October 8, 2024 17:59
@RachalCassity RachalCassity self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Backend-review-group approval confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants