API-40905-main-factory

[stiehlrod]

Summary

• Adds base factory, from which other model factories can inherit.
• Refactors EWS and POA factories.
• Adjusts tests based on factory changes.

Related issue(s)

• API-40905

What areas of the site does it impact?

new file:   modules/claims_api/spec/factories/claims_api_base_factory.rb
modified:   modules/claims_api/spec/factories/evidence_waiver_submissions.rb
modified:   modules/claims_api/spec/factories/power_of_attorney.rb
modified:   modules/claims_api/spec/lib/claims_api/bd_spec.rb
modified:   modules/claims_api/spec/requests/v1/forms/2122_spec.rb
modified:   modules/claims_api/spec/requests/v1/forms/rswag_2122_spec.rb
modified:   modules/claims_api/spec/requests/v2/veterans/power_of_attorney/power_of_attorney_spec.rb
modified:   modules/claims_api/spec/shared_reporting_helper.rb
modified:   modules/claims_api/spec/sidekiq/poa_vbms_upload_job_spec.rb
modified:   modules/claims_api/spec/sidekiq/report_monthly_submissions_spec.rb
modified:   modules/claims_api/spec/sidekiq/shared_reporting_examples_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 340 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/spec/factories/claims_api_base_factory.rb (+49/-0) modules/claims_api/spec/factories/evidence_waiver_submissions.rb (+7/-30) modules/claims_api/spec/factories/power_of_attorney.rb (+10/-29) modules/claims_api/spec/lib/claims_api/bd_spec.rb (+3/-3) modules/claims_api/spec/requests/v1/forms/2122_spec.rb (+2/-2) modules/claims_api/spec/requests/v1/forms/rswag_2122_spec.rb (+5/-5) modules/claims_api/spec/requests/v2/veterans/power_of_attorney/power_of_attorney_spec.rb (+1/-1) modules/claims_api/spec/shared_reporting_helper.rb (+1/-1) modules/claims_api/spec/sidekiq/poa_vbms_upload_job_spec.rb (+91/-86) modules/claims_api/spec/sidekiq/report_monthly_submissions_spec.rb (+6/-6) modules/claims_api/spec/sidekiq/shared_reporting_examples_spec.rb (+0/-2) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger