API-40554-version-2

[stiehlrod]

Summary

• Adds maximum request example.
• Updates dev/swagger & prod/swagger.

Related issue(s)

• API-40554

Testing done

• New code is covered by unit tests
• Check docs in local env: http://localhost:3000/services/claims/docs/swagger/index.html?urls.primaryName=Claims%20API%20V2%20Docs

Screenshots

What areas of the site does it impact?

modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified:   modules/claims_api/app/swagger/claims_api/v2/production/swagger.json
new file:   modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/valid_526_maximum.json
modified:   modules/claims_api/spec/requests/v2/veterans/rswag_526_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

If you can figure out how to update this line on the fly, please let me know.

[rockwellwindsor-va]

@stiehlrod I suspect the new fixture is probably the way to go. Do we also want this removed from the 202 example below this in the docs?

It is also still in the synchronous endpoint example (and 202) so also wondering if that needs to be removed

[rockwellwindsor-va]

I believe this JSON file needs a newline at the bottom of it (so a line 217 that is empty) otherwise it will keep getting this red mark on it and eventually may conflict with something if it does get formatted.

Not really my nit, just something I think gets enforced at some level for the app that I have run into.