Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMPLE_FORMS] feat: update form 21-4142 with new pdf form and expiration date #18792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pennja
Copy link
Contributor

@pennja pennja commented Oct 8, 2024

Summary

  • This work updates the form PDF template, form mappings, and stamp locations for newly updated form 21-4142

Related issue(s)

Testing done

  • Logic is already covered by unit tests

Requested Feedback

Any

@pennja pennja requested review from a team as code owners October 8, 2024 19:54
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1703-update-21-4142/main/main October 8, 2024 19:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to jap/simple-forms/1703-update-21-4142/main/main October 8, 2024 20:03 Inactive
Copy link

github-actions bot commented Oct 8, 2024

1 Warning
⚠️ This PR changes 275 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/simple_forms_api/app/form_mappings/vba_21_4142.json.erb (+163/-112)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants