Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

84372: Add column failure_notification_sent_at to AppealSubmission and AppealSubmissionUpload #18795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfong-adh
Copy link
Contributor

Summary

Migration to add failure_notification_sent_at to AppealSubmission and AppealSubmissionUpload

Related issue(s)

department-of-veterans-affairs/va.gov-team/issues/84372

Testing done

Migration verified locally

What areas of the site does it impact?

  • This impacts the AppealSubmission and AppealSubmissionUpload tables as it adds a new column (nullable column)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants