Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix view sorting being reset #2736

Merged
merged 1 commit into from
Jun 15, 2024
Merged

fix view sorting being reset #2736

merged 1 commit into from
Jun 15, 2024

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Jun 11, 2024

this PR fixes #2734.

When the Init method in the view.Table object is executed, the app.RefreshCustomViews method is called to reload the custom view, which triggers the ViewSettingsChanged event, ultimately causes the ui.Table object to reset the sorting of the user settings.

derailed
derailed approved these changes Jun 15, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Good catch! Thanks for the updates + cleanup Jayson!!

@derailed derailed merged commit 7380be9 into derailed:master Jun 15, 2024
2 of 3 checks passed
@derailed derailed mentioned this pull request Jun 15, 2024
Merged
@wjiec wjiec deleted the bugfix/view-reset branch June 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect pod containers displayed when using custom resource columns
2 participants
@wjiec @derailed