Puppeteer test #11
Merged
Puppeteer test #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4632d98.
ui/src/components/Organisms/CentralBankSecondFlow/CentralBankSecondFlow.tsx
Show resolved
Hide resolved
tamaskalcza-da-zz
approved these changes
Apr 28, 2021
| ] | ||
|
|
||
| const submitButton = isLoading | ||
| ? <Progress key="key" containerStyles={styles.dropdownSpinner} /> | ||
| : <Button key="button-Recipient" label={"Submit"} onClick={()=> { | ||
| : <Button key="button-Recipient" label={"Submit"} id='test-invoice-submit' onClick={()=> { |
There was a problem hiding this comment.
Minor: don't feel the need to add the prefix. This applies to other places as well.
Suggested change
| : <Button key="button-Recipient" label={"Submit"} id='test-invoice-submit' onClick={()=> { | |
| : <Button key="button-Recipient" label={"Submit"} id='invoice-submit' onClick={()=> { |
There was a problem hiding this comment.
yeah, made more sense with the classes.
keeping them kind of clarifies the reason (which is not enforced though, so no guarantee here)
so if you don't mind, let's keep the prefix for now
| console.log("Issuing stimulus...") | ||
| const restrictedStimulusDropdown = await page.waitForXPath('.//button[text()="Restricted Stimulus"]'); | ||
| await restrictedStimulusDropdown!.click() | ||
| const amountInput = await page.waitForSelector('#test-stimulus-amount'); |
There was a problem hiding this comment.
You might be able to simplify this. Don't mind if you leave it.
Suggested change
| const amountInput = await page.waitForSelector('#test-stimulus-amount'); | |
| await page.click('#test-stimulus-amount'); |
There was a problem hiding this comment.
thanks, i know, tried before multiple time, didn't work for unknown reason, so I left it.
i don't mind anyone tidying this up later ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.