Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work-in-Progress] Correct answers and points (#431) #433

Closed
wants to merge 2 commits into from

Conversation

Deep-Chill
Copy link
Contributor

@Deep-Chill Deep-Chill commented Jan 15, 2024

  • Added preliminary CorrectAnswer model
  • Added preliminary scoring logic in AssessmentCompleteAPIView

Need clarifications on :

  • If we should add a field for the correct answer in the CorrectAnswer model or use the one within the Question model
  • How exactly answer.measured relates to the Choice object that is the correct answer? Meaning if we have Answer.measured, what exactly do we check to ensure it is the correct answer?
  • Where should we return the score for the correct answers, if we should return it in the API View at all?

- Added preliminary CorrectAnswer model
- Added preliminary scoring logic in AssessmentCompleteAPIView

Need clarifications on :
- If we should add a field for the correct answer in the CorrectAnswer model or use the one within the Question model
- How exactly answer.measured relates to the Choice object that is the correct answer? Meaning if we have Answer.measured, what exactly do we check to ensure it is the correct answer?
- Where should we return the score for the correct answers, if we should at all?
Copy link
Contributor

@smirolo smirolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should be moved to its own subclass of ScoreCalculator into a get_scored_answers method.

@Deep-Chill
Copy link
Contributor Author

Superseded by #445

@Deep-Chill Deep-Chill closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants