Resolved segmentation fault in SDL2 audio #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rruption in callback.
Improved video performance; Added RGB curve control; Reduced the number of video restarts required in video menu.
Revisions to threading to more closely follow the hardware design. Compiles on Windows and Mac.
|
If you have time, would you mind trying a straight compile of the latest code in master. And let me know if Linux still has a segmentation fault? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved segmentation fault in SDL2 audio due to potential pointer corruption when tick() runs concurrently with fillaudio() by adding a spinlock. There is likely a OS native threading method to doing this, however the lock in the routine works in my testing OK with game runtime of over 24 hours measured.