Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'For anyone else' reminder about adding reactions #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilzbach
Copy link
Member

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @wilzbach!

@wilzbach
Copy link
Member Author

CC @WebDrake as you helped to shape the initial message and are generally interested in the bot.

Copy link

@WebDrake WebDrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice addition to me! I'd just keep an eye on behaviour to make sure that it doesn't result in lots of 👍 comments (instead of the wanted reactions).

I'd sound a note of caution about quite how informative these metrics will be though. Likely they will reflect more the preferences and interests of the people hanging round the dlang GitHub, more than the preferences and interests of the wider user community.

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the call for reactions is required but I like the suggestion to review even as a new/normal contributer.

@CyberShadow
Copy link
Member

I think at this point this is part of well-known GitHub culture, is this still worth the vertical space?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants