Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 39: Score is 0 when a token is in exactly 50% of the documents. #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue 39: Score is 0 when a token is in exactly 50% of the documents. #40

wants to merge 2 commits into from

Conversation

danerlt
Copy link

@danerlt danerlt commented May 24, 2024

image

@danerlt
Copy link
Author

danerlt commented May 24, 2024

@dorianbrown Can you help me review the code, please? Thank you.

@dorianbrown
Copy link
Owner

dorianbrown commented May 25, 2024 •
edited
Loading

@danerlt Sure thing, I'll have time to take a look sometime in the next week. Looking forward to it 👍

@dorianbrown
Copy link
Owner

I think this is a problem that needs addressing, and from what I can tell there are two ways to go (see this PR for some of the thoughts I just shared), so either fix the epsilon approach and keep the IDF as is, or remove that negativity checking, and go for this "smoothed" IDF function.

I'm not working on this topic as intensively as before, but do you know if there's a reason to prefer one of the two from a ranking perspective? Computationally the changed IDF function seems preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danerlt @dorianbrown