Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inquirer #156

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feature/inquirer #156

wants to merge 7 commits into from

Conversation

scattym
Copy link

@scattym scattym commented Mar 18, 2024

Description

Add the ability to choose the mfa type and the role through interactive shell instead of index.

This has been added as an optional dependency with fallback if the inquirer lib is not present. Only because I don't understand the policies of the package maintainer here, with respect to the increase to the dependency tree. Not a huge bump for inquirer, but I also had another thought around textual so that we might be able to implement role search capabilities through smart filtering.

Validate with extras_requires -> pip install -e .[inquirer]

Related Issue

N/A

Motivation and Context

We have a list of over 40 roles, which gets hard to navigate and/or search for.

How Has This Been Tested?

Validated with both inquirer installed and not installed.
Pytest run on 3.11.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have performed a self-review of my own code
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant