Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end revamp #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Anish-Agnihotri
Copy link

@Anish-Agnihotri Anish-Agnihotri commented Apr 30, 2020

Hey there,

Submitting a front-end revamp that was alluded to on Twitter.

What am I removing?

  • Each of the individual oracle .html pages. Instead, I have isolated the layout (header, google analytics tags, navigation) into a Layout component, and setup a /oracle/:name react-router path. Now, we can pull the oracle name from the URL, and fill in the data on the page. This way, we can just save all of our content in JSON/Markdown/MDX/your favourite format.
  • The vendor folder. Moving to component based architecture using node-modules. Plus, I don't think we need to have every single variation of every font-awesome icon included in the repo. Also no need for Bootstrap (simpler custom CSS), Chart.js (will be pulled from a node module), datatables (using React-tables-6 instead), jquery-easing, jquery.
  • scss/js folders. Moving to React + component-backed architecture so each component has its own CSS/JS.
  • image folder. Going to make a new static folder for image content, and add a optimization build process, so that all new images are auto-compressed and converted to JPEG/WebP on each build (for performance optimization).

What still needs to be done?

A lot, in complete honesty. I will likely get around to completing everything by the weekend, if not before the end-of-week. A short-list of things still left to do:

  • Fix reload bug (tables in Dashboard don't refresh on page change, should be a simple react-router-dom fix).
  • Charting. I've got the modal setup, and the API path being passed, just need to render the chart itself.
  • Oracle formatting (need to add tables, and build a little script that pulls the oracle data from whatever format into the pages).
  • Final performance optimizations, etc.
  • Documentation. I still have to go through and add comments everywhere to explain what does what.

100% open to conversation and suggestions, happy to make this even better. Current WIP Demo.

@Anish-Agnihotri
Copy link
Author

Hi @tomhschmidt!

I've got this PR open to merge frontend-revamp into master.

Did you want me to make a new branch and PR into frontend-revamp (like the PR on a new branch you mentioned on Twitter), or just use this PR thread?

@tomhschmidt
Copy link
Contributor

Oh sick! I somehow missed this. I'd vote in favor of just PRing into frontend-revamp (and I can PR some of the CSS too) and then we can eventually merge the whole thing and replace current master. How does that sound?

@skuhlmann skuhlmann mentioned this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants