Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forgotten return in case of invalid line format from memcache ascii client #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sivukhin
Copy link

I ran govanish linter (it still in the WIP phase) against godropbox repo and it found one suspicious place:

2023/12/24 17:03:42 it seems like your code vanished from compiled binary: func=[Stat], file=[/home/sivukhin/code/godropbox/repo/memcache/raw_ascii_client.go], line=[675], snippet:
	NewStatErrorResponse(err, shardEntries)

Obviously, this is a bug - return statement were forgotten.

This PR fixes this bug.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants