rubocop: fix build #154
Closed
rubocop: fix build #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegykz
force-pushed
the
issue/dry-configurable-warnings
branch
from
8fa46c6
to
955c0a1
Compare
|
Thanks for taking care of this, @olegykz! Would you actually mind splitting this work into two? A single PR with your rubocop fix would be fine (I'll merge regardless of tests), and then another PR that copies hanami/view#212 to fix the hamlit dependency? One both of those are in I'll cut a new release :) |
|
@timriley sure, I'll do it |
olegykz
force-pushed
the
issue/dry-configurable-warnings
branch
from
3288669
to
7c9afeb
Compare
|
hm, it seems something has changed in rubocop rules, as PR above has a green build |
|
@olegykz Yeah, that's odd! In this case I think we can probably just close this one for now, since main is good. I'll look to ship a release in the next ~2 days :) |
|
@timriley let's watch the build status, it may happen due to some inconsistency in CI between PR and master builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Rubocop issues introduced in #153
In order to get a green build I had to add
hamlit&hamlit-blockversion requirements as tests were failing forhamlitolder than2.16.0andhamlit-blockolder than0.7.1