Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: implement trans query condition: Status, TransType, CreateTime #428

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

wooln
Copy link
Contributor

@wooln wooln commented Jun 6, 2023

因该单测之前就有与别的单测的数据串扰问题,这次放水了相关单测了查询结果断言的精度(不放水的在注释中),单测中的持久层串扰参见issue: #427

@codecov-commenter
Copy link

Codecov Report

Merging #428 (1bca308) into main (90daddc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   96.02%   96.05%   +0.03%     
==========================================
  Files          57       57              
  Lines        4101     4136      +35     
==========================================
+ Hits         3938     3973      +35     
  Misses        118      118              
  Partials       45       45              
Impacted Files Coverage Δ
dtmsvr/api_http.go 92.91% <100.00%> (+0.67%) ⬆️
dtmsvr/storage/boltdb/boltdb.go 96.15% <100.00%> (+0.04%) ⬆️
dtmsvr/storage/redis/redis.go 98.67% <100.00%> (+0.01%) ⬆️
dtmsvr/storage/sql/sql.go 98.57% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wooln wooln force-pushed the feature-admin-query-condition branch from 1bca308 to 2a596ae Compare June 7, 2023 14:09
@wooln wooln marked this pull request as ready for review June 7, 2023 14:15
@yedf2 yedf2 merged commit 361bf79 into dtm-labs:main Jun 7, 2023
3 checks passed
@wooln wooln deleted the feature-admin-query-condition branch June 8, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants