Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cancellable sleep #20

Closed
wants to merge 1 commit into from

Conversation

WqyJh
Copy link
Contributor

@WqyJh WqyJh commented Dec 28, 2023

If context.Context got timeout or canceled, go routines calling time.Sleep cannot be cancelled, and the following redis calls would fail. Therefore, it's better to support cancellable sleep to make it fail fast.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (3bdca0f) 85.61% compared to head (c3ad74e) 83.00%.
Report is 2 commits behind head on main.

Files Patch % Lines
batch.go 52.63% 7 Missing and 2 partials ⚠️
client.go 60.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   85.61%   83.00%   -2.61%     
==========================================
  Files           3        3              
  Lines         424      459      +35     
==========================================
+ Hits          363      381      +18     
- Misses         45       58      +13     
- Partials       16       20       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WqyJh WqyJh closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant