Support EVALSHA #21
Support EVALSHA #21
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 85.61% 83.03% -2.58%
==========================================
Files 3 3
Lines 424 395 -29
==========================================
- Hits 363 328 -35
- Misses 45 46 +1
- Partials 16 21 +5 ☔ View full report in Codecov by Sentry. |
|
@yedf2 please help review |
|
please take a look at the Codecov report |
script.go
Outdated
| import "github.com/redis/go-redis/v9" | ||
|
|
||
| var ( | ||
| deleteScript = redis.NewScript(`redis.call('HSET', KEYS[1], 'lockUntil', 0) |
There was a problem hiding this comment.
Can you add a new line at the first of the script? That may make the code more readable
Working on this |
|
Coverage fixed |
batch.go
Outdated
| @@ -192,10 +164,25 @@ func (c *Client) weakFetchBatch(ctx context.Context, keys []string, expire time. | |||
| go func(i int) { | |||
| defer wg.Done() | |||
| r, err := c.luaGet(ctx, keys[i], owner) | |||
| ticker := time.NewTimer(c.Options.LockSleep) | |||
There was a problem hiding this comment.
Why not put ticker inside the for loop? Code can be cleaner
There was a problem hiding this comment.
reuse & reduce allocation
There was a problem hiding this comment.
The performance gained in this way should be very very little and can be ignored. Why not use the cleaner way?
EVALSHAto reduce network & cpu overhead ofEVAL.time.Sleepfor failfast on context cancelled.