Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTML support in RMF title #4672

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Add HTML support in RMF title #4672

merged 1 commit into from
Jul 2, 2024

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jun 20, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1201807753394693/1207619945513388/f

Description

Support HTML text in RMF title

Steps to test this PR

  • Change endpoint in RemoteMessagingService to https://www.jsonblob.com/api/1248254773076811776
  • Fresh install
  • Finish onboarding
  • Check new message appears and title looks fine
  • Tap fire button and clear data
  • Check the same message appears but with a line break in the title

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag marked this pull request as ready for review June 21, 2024 15:22
@nalcalag nalcalag requested a review from malmstein as a code owner June 21, 2024 15:22
cmonfortep
cmonfortep approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalcalag nalcalag merged commit a68e38f into develop Jul 2, 2024
7 checks passed
@nalcalag nalcalag deleted the feature/noelia/rmf_support_html_title branch July 2, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep cmonfortep approved these changes

@malmstein malmstein Awaiting requested review from malmstein malmstein is a code owner

Assignees

@cmonfortep cmonfortep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nalcalag @cmonfortep