Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixels for importing passwords via desktop sync #4692

Open
wants to merge 1 commit into
base: feature/craig/import_passwords_via_sync
Choose a base branch
from

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jun 25, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207657337829081/f

Description

General pixels for importing via desktop sync.

Steps to test this PR

Suggested logcat filter: "Pixel sent: "

  • Fresh install
  • Visit password management screen

Import Passwords (blue button)

  • Tap on blue "Import Passwords" button
  • Verify m_autofill_logins_import_no_passwords in log

No action taken

  • Tap back without doing anything else; verify m_autofill_logins_import_no-action in log

Import Passwords (from overflow menu)

  • Manually add a password. Then return to password management screen
  • Tap on overflow menu "Import Passwords"; verify m_autofill_logins_import in log

Get Desktop Browser

  • Tap on Get Desktop Browser button; verify m_autofill_logins_import_get_desktop in log
  • Tap blue Share Download Link button; verify m_get_desktop_share in log. Cancel share sheet.
  • Tap on duckduckgo.com/browser link; verify m_get_desktop_copy in log

Sync With Desktop

  • Tap back
  • Tap Sync With Desktop button; verify m_autofill_logins_import_sync in log

Copy link
Member Author

CDRussell commented Jun 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on Graphite Graphite

@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch from 1af7c9d to a215e3c Compare June 25, 2024 13:46
@CDRussell CDRussell marked this pull request as ready for review June 25, 2024 13:48
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch 2 times, most recently from fdf1631 to 9e5a998 Compare June 25, 2024 16:01
@CDRussell CDRussell assigned CDRussell and cmonfortep and unassigned CDRussell Jun 25, 2024
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync branch from f97cee5 to 3a135f9 Compare June 26, 2024 16:45
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch from 9e5a998 to ea4e47d Compare June 26, 2024 16:45
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync branch from 3a135f9 to 4b95e2c Compare June 27, 2024 09:30
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch from ea4e47d to a4db5fc Compare June 27, 2024 09:30
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync branch from 4b95e2c to fa49936 Compare June 27, 2024 09:53
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch 2 times, most recently from 365dec6 to 9df93ce Compare June 28, 2024 11:48
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync branch from fa49936 to ce23b9d Compare June 28, 2024 14:59
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch from 9df93ce to 33646f3 Compare June 28, 2024 14:59
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync branch from ce23b9d to ba126c4 Compare July 2, 2024 22:29
@CDRussell CDRussell force-pushed the feature/craig/import_passwords_via_sync_pixels branch from 33646f3 to f57b2a3 Compare July 2, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants