-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixels for importing passwords via desktop sync #4692
base: feature/craig/import_passwords_via_sync
Are you sure you want to change the base?
Pixels for importing passwords via desktop sync #4692
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
1af7c9d
to
a215e3c
Compare
fdf1631
to
9e5a998
Compare
f97cee5
to
3a135f9
Compare
9e5a998
to
ea4e47d
Compare
3a135f9
to
4b95e2c
Compare
ea4e47d
to
a4db5fc
Compare
4b95e2c
to
fa49936
Compare
365dec6
to
9df93ce
Compare
fa49936
to
ce23b9d
Compare
9df93ce
to
33646f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ce23b9d
to
ba126c4
Compare
33646f3
to
f57b2a3
Compare
Task/Issue URL: https://app.asana.com/0/72649045549333/1207657337829081/f
Description
General pixels for importing via desktop sync.
Steps to test this PR
Suggested logcat filter:
"Pixel sent: "
Import Passwords (blue button)
m_autofill_logins_import_no_passwords
in logNo action taken
m_autofill_logins_import_no-action
in logImport Passwords (from overflow menu)
m_autofill_logins_import
in logGet Desktop Browser
Get Desktop Browser
button; verifym_autofill_logins_import_get_desktop
in logShare Download Link
button; verifym_get_desktop_share
in log. Cancel share sheet.duckduckgo.com/browser
link; verifym_get_desktop_copy
in logSync With Desktop
Sync With Desktop
button; verifym_autofill_logins_import_sync
in log