refactor: leverage Go 1.20's http.ResponseController #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
refactor/1.20-deadline
branch
from
f31e372
to
45e768a
Compare
This was referenced Apr 25, 2023
dunglas
force-pushed
the
refactor/1.20-deadline
branch
2 times, most recently
from
57e499c
to
817bb40
Compare
|
This is now green. We just have to wait for the release of Caddy 2.7. |
|
Looks like the 2.7 version of Caddy is released. Time to update finally our Mercure installations :) Thanks! |
dunglas
force-pushed
the
refactor/1.20-deadline
branch
from
817bb40
to
1e452f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the new
"net/http".ResponseControllertype introduced in Go 1.20 to improve and simplify timeout management.These 2 PRs are needed for tests to be green:
ResponseWriter.Unwrap(), prep for Go 1.20'sResponseControllercaddyserver/caddy#5509