Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mercure container port can be modified #868

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

coibib
Copy link
Contributor

@coibib coibib commented Jan 30, 2024

Due to Openshift requirements, containers can not be exposed on ports < 1024. The mercure container is mapped on port 80.

Signed-off-by: François Bibron <[email protected]>
Signed-off-by: François Bibron <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@coibib coibib changed the title Fix/target port fix: Mercure container port can be modified Jan 30, 2024
Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dunglas dunglas merged commit 2dd3b92 into dunglas:main Jan 31, 2024
11 checks passed
@dunglas
Copy link
Owner

dunglas commented Jan 31, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants