Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR:auth πŸ” + Tailwind ✨ #120

Merged
merged 46 commits into from
Dec 1, 2022
Merged

PR:auth πŸ” + Tailwind ✨ #120

merged 46 commits into from
Dec 1, 2022

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Nov 14, 2022

closes #121

This is meant to expand the tutorial by adding generic authentication through different providers.

This is very much a work-in-progress that is currently blocked because of "the auth_plug package is not properly working on recent version of Elixir" issue

Just pushing it for future reference πŸ˜„

Adding auth file to track progress of implementation.
@LuchoTurtle LuchoTurtle marked this pull request as draft November 14, 2022 09:51
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #120 (f2a91f6) into main (2834bec) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f2a91f6 differs from pull request most recent head 7f87878. Consider uploading reports for the commit 7f87878 to get more accurate results

@@            Coverage Diff            @@
##              main      #120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         6    +2     
  Lines           17        18    +1     
=========================================
+ Hits            17        18    +1     
Impacted Files Coverage Ξ”
lib/chat_web/channels/room_channel.ex 100.00% <100.00%> (ΓΈ)
lib/chat_web/controllers/auth_controller.ex 100.00% <100.00%> (ΓΈ)
lib/chat_web/controllers/page_controller.ex 100.00% <100.00%> (ΓΈ)
lib/chat_web/views/page_view.ex 100.00% <100.00%> (ΓΈ)

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic
Copy link
Member

nelsonic commented Nov 16, 2022

@nelsonic nelsonic changed the title [PR] Adding auth PR:auth πŸ” + Tailwind ✨ Nov 17, 2022
@nelsonic
Copy link
Member

Ok, I've got auth_plug working on my localhost: βœ…

image

Don't have more time to spend on tidying the UI/layout so assigning back to you @LuchoTurtle πŸ‘Œ

@nelsonic nelsonic removed their assignment Nov 17, 2022
@nelsonic nelsonic removed the BLOCKED label Nov 17, 2022
@LuchoTurtle
Copy link
Member Author

Well, with this fixed, the PR should be admissable for review.

If you have any feedback on the UI, please comment here @nelsonic πŸ‘

@nelsonic
Copy link
Member

Gonna take a final look at this when I get back to my desk. ⏳ (thanks!)

@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Nov 23, 2022
@nelsonic nelsonic moved this from More ToDo ThanCanEver Be Done to In progress in Nelson's List Nov 23, 2022
@nelsonic nelsonic mentioned this pull request Nov 29, 2022
4 tasks
@nelsonic
Copy link
Member

Sorry this has taken me a while to get back to ... ⏳
Looking at it now! πŸ§‘β€πŸ’»

@nelsonic
Copy link
Member

nelsonic commented Dec 1, 2022

Before Tailwind:
image

With compact/minimalist Tailwind UI:
image

Sadly, some genius decided to write swear words in our App. It's what we get for not enforcing auth. πŸ™„
Anyway,

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @LuchoTurtle! πŸ‘Œ
We've been meaning to add auth #54 for years! πŸ” πŸš€

@nelsonic nelsonic merged commit 39eec2a into main Dec 1, 2022
Nelson's List automation moved this from In progress to Done Dec 1, 2022
@nelsonic nelsonic deleted the add-auth branch December 1, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Nelson's List
  
Done
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

Add Tailwind CSS ✨
2 participants