This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Add data source method for configuring the initial frame of the empty data set view. Closes #147 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting. Will review soon. |
dzenbot
changed the title
|
@dzenbot I just want to give this PR a bump. We've been using this approach in our app for a while now and we're happy with it so far. |
|
Great to know @wlisac! |
|
I have set another object as Datasource but i am not getting callbacks over there. Can you tell why? |
|
This approach is great. Why is it still not merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue documented here: #147