This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Fix fade-in effect #257
Open
Fix fade-in effect #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -448,6 +448,9 @@ - (void)dzn_reloadEmptyDataSet | |||
|
|
|||
| DZNEmptyDataSetView *view = self.emptyDataSetView; | |||
|
|
|||
| // Configure empty dataset fade in display | |||
| view.fadeInOnDisplay = [self dzn_shouldFadeIn]; | |||
There was a problem hiding this comment.
This line was moved up a little because in some cases, the method didMoveToSuperview was called before the value fadeInOnDisplay was set up. So I thought it would be better to set it before addSubview.
|
Interesting approach. Will have a look soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fade-in effect.
Somehow when I run the samples in simulators, the fade-in didn't appear. So I made a few changes. It worked for all the 3 sample applications.