Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration #5252

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

reinhapa
Copy link
Member

Try to reduce complexity and sonar warnings

Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a second look at my comments

Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@reinhapa reinhapa force-pushed the simplify-configration branch 2 times, most recently from 5faad19 to 6aa5536 Compare March 26, 2024 13:31
@dizzzz dizzzz changed the title Simplify configration Simplify configuration Apr 29, 2024
@reinhapa reinhapa force-pushed the simplify-configration branch 2 times, most recently from 428e972 to e25b0d9 Compare April 30, 2024 13:15
Copy link

sonarcloud bot commented Apr 30, 2024

@line-o line-o requested review from line-o and dizzzz April 30, 2024 14:11
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks completely fine to me! Thanks for this @reinhapa
Only the commit messages need to follow our commit message format then this can go in.
Or do you want to do further changes before this should be merged?

Copy link

sonarcloud bot commented Jul 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants