Expose route for context #1128
Expose route for context #1128
Conversation
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
pkg/context/context.go
Outdated
| @@ -92,6 +94,16 @@ func New(span *tracing.Span) *Context { | |||
| return ctx | |||
| } | |||
|
|
|||
| // SetRoute sets the route. | |||
| func (ctx *Context) SetRoute(route routers.Route) { | |||
There was a problem hiding this comment.
this context contains general protocol for multiple protocols. Such as HTTP, GRPC... Maybe update this name to SetHTTPRoute, GetHTTPRoute or make the route interface{} SetRoute(protocols.Route)?
xxx7xxxx
force-pushed
the
redirectorv2
branch
from
72332c6
to
00ff123
Compare
| @@ -25,6 +25,7 @@ import ( | |||
|
|
|||
| "github.com/megaease/easegress/v2/pkg/context" | |||
| "github.com/megaease/easegress/v2/pkg/filters" | |||
| httprouters "github.com/megaease/easegress/v2/pkg/object/httpserver/routers" | |||
There was a problem hiding this comment.
Looks good to me. Just a little advice. How about add a type alias in github.com/megaease/easegress/v2/pkg/protocols/httpprot say:
var Route = github.com/megaease/easegress/v2/pkg/object/httpserver/routers.Route
then
prefix := route.(httpprot.Route).GetPathPrefix()
The code produce exactly same result. But for future developers, it may a little bit easier for them to find right interface?
There was a problem hiding this comment.
That will cause an import cycle.
Have tried to design a universal exposed route type system which is complicated and unnecessary, so I turned to the minimum way to implement the current requirement.
Will try to update Gateway API to v1.0.0(GA), there's tons of broken dependencies to fix...