feat(news-ticker): Icon or image for each item, iteration on styles for EC and EU - FRONT-4463 #3447
Conversation
…ntermediate screens - FRONT-4463
planctus
added
tag: markup changes
tag: data change
and removed
tag: breaking change
labels
planctus
changed the title
| {% include '@ecl/icon/icon.html.twig' with { | ||
| icon: _item.icon|merge({ | ||
| path: _icon_path, | ||
| name: _item.icon.name, |
There was a problem hiding this comment.
can't we default the icon name to 'information' (at least until next major version)?
That way there won't be breaking changes here
There was a problem hiding this comment.
mmh..i'd say no, because we would alter the behavior of the component, currently you can set or not an icon for each item, if we default it to "something" it would always be there instead, and it would be totally arbitrary to show the info icon at this point. It would not work as backward compatibility, for that to happen we should check if in any of the item there is an icon and in case there is none we could "assume" that it's "old data" and apply this fallback but it seems an overhead for the template to do so.
| @@ -27,20 +28,25 @@ $news-ticker: null !default; | |||
| .ecl-news-ticker__icon { | |||
| fill: var(--c-p); | |||
| flex-shrink: 0; | |||
| margin-inline-start: map.get($news-ticker, 'padding-horizontal'); | |||
| height: 1.5rem; | |||
There was a problem hiding this comment.
we should use the sass maps for the icon size
| link: exampleLink, | ||
| icon: { | ||
| name: 'euro', |
There was a problem hiding this comment.
maybe we should have different icons on some slides, to showcase this possibility
There was a problem hiding this comment.
Done it, although for some reasons i was explicitely requested to use the euro icon..
planctus
changed the title
…component-library into FRONT-4463-News-ticker
No description provided.