Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): EU styles - FRONT-4451 #3449

Merged
merged 7 commits into from
Jul 12, 2024
Merged

feat(tabs): EU styles - FRONT-4451 #3449

merged 7 commits into from
Jul 12, 2024

Conversation

planctus
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 24, 2024

@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 10:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 12:08 Inactive
@planctus planctus marked this pull request as ready for review June 24, 2024 12:18
@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 12:26 Inactive
@@ -36,11 +36,16 @@ $button-width: 44px;
margin: 0;
padding-inline-start: 0;
transition-duration: 0.4s;

.ecl-tabs[data-ecl-auto-initialized] & {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this rule will be applied, as there is no .ecl-tabs children of .ecl-tabs
Also targeting auto-initialized data would exclude user doing the initialization on their side. If this is to delay the css after javascript init, better add a css class from the js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm confused, this selector is nested in the .ecl-tabs-list selector, so this results in:
.ecl-tabs[data-ecl-auto-initialized] .ecl-tabs-list and it is correctly applied.

the data-ecl-auto-initialized attribute might sound confusing, but we do this in all of our classes in the init() method, so it's not only limited to implmentations using the autoInit.
this.element.setAttribute('data-ecl-auto-initialized', 'true');

@github-actions github-actions bot temporarily deployed to pull request July 3, 2024 06:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 3, 2024 08:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 11, 2024 08:10 Inactive
@planctus planctus merged commit 727058e into v4-dev Jul 12, 2024
7 checks passed
@planctus planctus deleted the FRONT-4451-EU-tabs branch July 12, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants