Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added metrics provider #415

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added metrics provider #415

wants to merge 5 commits into from

Conversation

tcalmant
Copy link
Contributor

  • If the provider.enabled option of sensinact.metrics is true, the metrics bulk DTO is pushed to the gateway.
  • Added a test to ensure the provider exists
  • Fixed the JVM gauge sometimes not being registered

@tcalmant
Copy link
Contributor Author

tcalmant commented Jun 25, 2024 •
edited
Loading

Looks like the whiteboard metrics name must be normalized:

Exception in thread "Thread-2" java.lang.IllegalArgumentException: Illegal character 58 at index 63 of topic string: METADATA/metrics/metrics/sensinact/whiteboard-act-request-https://eclipse-org/sensinact/model-provider-svc-rc

@tcalmant tcalmant removed the request for review from juergen-albert July 2, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyjward timothyjward Awaiting requested review from timothyjward

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tcalmant